Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete lint command #2964

Merged
merged 2 commits into from
Oct 13, 2022
Merged

chore: delete lint command #2964

merged 2 commits into from
Oct 13, 2022

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Oct 13, 2022 •
edited
Loading

🔥

This command is a thin layer around npm run lint and isn't really doing much.

docs change: https://app.gitbook.com/o/-LBKDRmeoAGTb1M5X51f/s/-LBKK1y7h_XWAtuRJG9X-4037718589/~/changes/LC7DTXHI4GHNYirt7K9z/cli

@malept
Copy link
Member

malept commented Oct 13, 2022

One day I want to reintroduce lint to validate that, among other things, the rendered Forge config is valid. But that's not happening before we hit v6 stable.

@malept
Copy link
Member

malept commented Oct 13, 2022

As in the install PR: Please remove references in electronforge.io when this is merged!

@erickzhao erickzhao requested a review from a team October 13, 2022 23:09
@malept
Copy link
Member

malept commented Oct 13, 2022

I don't know why that same zip file keeps getting changed in these PRs 🤔

@erickzhao
Copy link
Member Author

@malept ah oops. It seems to change every time I run bolt test:fast locally.

@malept
Copy link
Member

malept commented Oct 13, 2022

It seems to change every time I run bolt test:fast locally.

That's weird. Can you file a bug for that?

@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #2964 (d409466) into main (6b215b0) will decrease coverage by 1.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
- Coverage   73.46%   72.40%   -1.06%     
==========================================
  Files          67       66       -1     
  Lines        2178     2142      -36     
  Branches      427      424       -3     
==========================================
- Hits         1600     1551      -49     
- Misses        370      394      +24     
+ Partials      208      197      -11
Impacted Files Coverage Δ
packages/api/core/src/api/index.ts 88.88% <100.00%> (+24.37%) ⬆️
packages/maker/squirrel/src/MakerSquirrel.ts 28.57% <0.00%> (-47.62%) ⬇️
packages/maker/wix/src/MakerWix.ts 40.90% <0.00%> (-40.91%) ⬇️
packages/maker/appx/src/MakerAppX.ts 43.10% <0.00%> (-17.25%) ⬇️
packages/maker/base/src/Maker.ts 66.66% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b215b0...d409466. Read the comment docs.

@erickzhao erickzhao merged commit 362099a into main Oct 13, 2022
@erickzhao erickzhao deleted the no-lint branch October 13, 2022 23:55
@erickzhao erickzhao mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept left review comments

@georgexu99 georgexu99 georgexu99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickzhao @malept @georgexu99